Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental: support for trailing commas #3804

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Experimental: support for trailing commas #3804

merged 2 commits into from
Jan 10, 2023

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu [email protected]
Fixes p4lang/p4-spec#1205

@mihaibudiu
Copy link
Contributor Author

To be discussed in the LDWG.
Notice that this is a grammar-only change, so it should not affect any backend.

Changed error messages
c125954 
Signed-off-by: Mihai Budiu <[email protected]>
jafingerhut
jafingerhut approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, including the grammar changes. I did not think carefully about whether there are other grammar rules that were not changed, that could be similarly modified.

@mihaibudiu
Copy link
Contributor Author

I will merge this change, since the LDWG seems to have been in approval.

@mihaibudiu mihaibudiu merged commit 199f6bd into p4lang:main Jan 10, 2023
@mihaibudiu mihaibudiu deleted the trailing-comma branch January 10, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we allow trailing comma in P4?
2 participants
@mihaibudiu @jafingerhut